[PATCH] D100651: [AIX] Support of Big archive (read)

[James Henderson via Phabricator via llvm-commits]

jhenderson added a reviewer: gbreynoo.
jhenderson added a comment.

I've not got the time to review this properly currently.

Of the brief glance I gave this so far:

1. There doesn't seem to be as much testing as I'd expect given the amount of new code.
2. Using a prebuilt binary should generally be avoided. You should create the archive at test run time, by using llvm-ar or some other tool (e.g. expanding yaml2obj to support this file format).
3. I'm not a fan of the complication of the existing archive header code by converting it into a virtual hierarchy. That being said, I haven't looked at the rest of the code properly to give any thought as to whether there's a better approach.

Finally, what's the use-case? Why do you need this functionality?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100651/new/

https://reviews.llvm.org/D100651