[PATCH] D101142: [SimplifyCFG/JumpThreading] Transfer loop metadata to new latch.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 00:36:04 PDT 2021


lebedev.ri added a comment.

Patch's subject is wrong. This doesn't "Transfer loop metadata to new latch.", it prevents folding.
Or is this a wrong diff?

In D101142#2711280 <https://reviews.llvm.org/D101142#2711280>, @Meinersbur wrote:

> LoopHeaders is already used by both SimplifyCFG and JumpThreading. If it is stale and incomplete, it is already a problem now.
>
> Do you have an alternative suggestion?

I don't know, but not introducing more problems by using problematic interface (`LoopHeaders`) seems like a good suggestion.
if you already have metadata, why do you need `LoopHeaders` ?
But basically, i'm unconvinced that we want to restrict simplifycfg in this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101142/new/

https://reviews.llvm.org/D101142



More information about the llvm-commits mailing list