[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 23:49:03 PDT 2021


rjmccall added a comment.

What is the purpose of the builtin?  Where is it being used?  Typically you *can't* change the signature of a builtin because the builtin is itself a language feature that's documented to have a particular signature.  If you've made a builtin purely for use in generated AST, that's pretty unfortunate, and you should consider whether you actually have to do that instead of e.g. synthesizing a call to an allocation function the same way that we do in `new` expressions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100739/new/

https://reviews.llvm.org/D100739



More information about the llvm-commits mailing list