[lld] 88b76cb - [lld/mac] slightly improve weak-private-extern.s test

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 19:43:06 PDT 2021


Author: Nico Weber
Date: 2021-04-22T22:42:48-04:00
New Revision: 88b76cb130bb88bd20c9a07dc546f5a5efc3fc20

URL: https://github.com/llvm/llvm-project/commit/88b76cb130bb88bd20c9a07dc546f5a5efc3fc20
DIFF: https://github.com/llvm/llvm-project/commit/88b76cb130bb88bd20c9a07dc546f5a5efc3fc20.diff

LOG: [lld/mac] slightly improve weak-private-extern.s test

- __got is in --bind output, so print that too (makes the test
  a bit stronger)
- WEAK_DEFINES, BINDS_TO_WEAK are in the mach-o header, so
  --private-header is enough, no need for --all-headers
  (makes the test a bit easier to work with when it fails)

Differential Revision: https://reviews.llvm.org/D101065

Added: 
    

Modified: 
    lld/test/MachO/weak-private-extern.s

Removed: 
    


################################################################################
diff  --git a/lld/test/MachO/weak-private-extern.s b/lld/test/MachO/weak-private-extern.s
index 641a88525883..5c34318c4c76 100644
--- a/lld/test/MachO/weak-private-extern.s
+++ b/lld/test/MachO/weak-private-extern.s
@@ -3,11 +3,11 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %s -o %t.o
 # RUN: %lld -dylib %t.o -o %t.dylib -lSystem
 
-# RUN: llvm-objdump --macho --weak-bind %t.dylib | FileCheck %s
+# RUN: llvm-objdump --macho --bind --weak-bind %t.dylib | FileCheck %s
 # CHECK-NOT: __got
 # CHECK-NOT: __la_symbol_ptr
 
-# RUN: llvm-objdump --macho --all-headers %t.dylib | \
+# RUN: llvm-objdump --macho --private-header %t.dylib | \
 # RUN:     FileCheck --check-prefix=HEADERS %s
 # HEADERS-NOT: WEAK_DEFINES
 # HEADERS-NOT: BINDS_TO_WEAK


        


More information about the llvm-commits mailing list