[PATCH] D100894: [CMake][llvm] Using -D in COMPILE_DEFINITIONS can create a lone -D w/generator-expressions

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 18:42:46 PDT 2021

Previous message: [PATCH] D100894: [CMake][llvm] Using -D in COMPILE_DEFINITIONS can create a lone -D w/generator-expressions
Next message: [PATCH] D100895: [CMake][llvm] LLVM_DEFINITIONS are a list, not space separated
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100894/new/

https://reviews.llvm.org/D100894

Previous message: [PATCH] D100894: [CMake][llvm] Using -D in COMPILE_DEFINITIONS can create a lone -D w/generator-expressions
Next message: [PATCH] D100895: [CMake][llvm] LLVM_DEFINITIONS are a list, not space separated
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list