[PATCH] D101067: [X86][AMX] Try to hoist AMX shapes' def
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 22 18:40:54 PDT 2021
xiangzhangllvm added inline comments.
================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:199
MIRef MIR(MI, MBB);
- if (BBVisitedInfo[MBB].LastShape < MIR)
- BBVisitedInfo[MBB].LastShape = MIR;
- ShapeBBs.insert(MBB);
+ auto I = llvm::lower_bound(ShapeBBs[MBB], MIR);
+ if (*I != MIR)
----------------
ShapeBBs[MBB] may both contains the Row_def and Col_def, and they may be in different BBs, The Pos of them in their BB my be equal, So use lower_bound here seems not good. Because it may duplicated insert X_def at line 201.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101067/new/
https://reviews.llvm.org/D101067
More information about the llvm-commits
mailing list