[PATCH] D100446: [Transforms][Debugify] Fix "Missing line" false alarm on PHI nodes

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 18:04:46 PDT 2021


xiangzhangllvm added a comment.

Thanks for your detailed explanation,  In my eyes, D75242 <https://reviews.llvm.org/D75242> eliminated uncommon "warnings" (only pass generate PHI node), but generate common "warnings" (all pass with PHI node ).
Let me first +1 for this patch if no other reviewers object.
LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100446/new/

https://reviews.llvm.org/D100446



More information about the llvm-commits mailing list