[PATCH] D100651: [AIX] Support of Big archive (read)

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

Added a few others that review binutils. Thanks for the patch!

Looks like the Windows pre-merge check is failing: https://reviews.llvm.org/harbormaster/unit/view/554528/. I can reproduce locally with `ninja check-llvm-object`. It looks like the archive is empty? Maybe try regenerating it and uploading the patch again.

  $ file llvm/test/Object/Inputs/Big.a
  llvm/test/Object/Inputs/Big.a: empty

While building this, there's a warning about an unhandled switch:

  /home/rupprecht/src/llvm-project/llvm/lib/Object/ArchiveWriter.cpp:132:11: warning: enumeration value 'K_XCOFF' not handled in switch [-Wswitch]
    switch (Kind) {
            ^
  /home/rupprecht/src/llvm-project/llvm/lib/Object/ArchiveWriter.cpp:197:11: warning: enumeration value 'K_XCOFF' not handled in switch [-Wswitch]
    switch (Kind) {
            ^

(Didn't get around to reviewing the main source changes in depth yet...)



================
Comment at: llvm/test/Object/archive-big-read.test:1
+RUN: cd %p
+
----------------
Instead of cd'ing to the source tree, these commands should be executed in the build tree -- i.e. drop this line, and change below to `llvm-ar tv %p/Inputs/Big.a`


================
Comment at: llvm/test/Object/archive-big-read.test:3
+
+Test reading an archive created by AIX ar (Big Archive)
+RUN: env TZ=GMT llvm-ar tv Inputs/Big.a | FileCheck %s -strict-whitespace
----------------
nit: it isn't technically required, but this should start with a comment (i.e. `# Test reading ...`) to separate it more clearly from run/check commands


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100651/new/

https://reviews.llvm.org/D100651