[PATCH] D101116: [ELF] Support .rela.eh_frame with unordered r_offset values

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 16:06:58 PDT 2021


MaskRay added inline comments.


================
Comment at: lld/ELF/InputSection.cpp:1329
 void EhInputSection::split(ArrayRef<RelTy> rels) {
+  // getReloc expects the relocations to be sorted by r_offset. See the comment
+  // in scanRelocs.
----------------
It is unfortunate that there are two pieces of code.
`RelTy` is parametric so we cannot add a member in `EhInputSection` caching the input relocations.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101116/new/

https://reviews.llvm.org/D101116



More information about the llvm-commits mailing list