[PATCH] D99987: [NewGVN] Track simplification dependencies for phi-of-ops.
    Alina Sbirlea via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Apr 22 15:28:16 PDT 2021
    
    
  
asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.
Thank you! Looks good.
A note for the dependent patch, if it will also adds predicate users, perhaps the name `addAdditionalUsers` need not be overloaded (though `addAdditionalAndPredicateUsers` is a bit verbose).
If it makes sense to inline the predicate API into the new one, and remove it, I'd be ok with that.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99987/new/
https://reviews.llvm.org/D99987
    
    
More information about the llvm-commits
mailing list