[PATCH] D101072: [lld] reformat multi-line error messages in source code

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 14:37:35 PDT 2021


oontvoo added a comment.

In D101072#2710088 <https://reviews.llvm.org/D101072#2710088>, @int3 wrote:

> Hm, I'd prefer not to have to see spurious clang-format messages.
>
> It also means that I can't just `clang-format -i` the entire directory any more. I know there's clang-format-diff, but sometimes cleaning up the whole directory is what's needed...
>
> How about introducing a `multilineError` function that takes multiple string parameters instead and adds the appropriate `\n` and `>>>` bits?

+1 my $0.02, I'd personally prefer the code to be in a state where running clang-format in a clean checkout does not change anything. 
Otherwise, any change made to such code could potentially lead to spurious formatting changes, which is a bit annoying.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101072/new/

https://reviews.llvm.org/D101072



More information about the llvm-commits mailing list