[PATCH] D100523: [lld][MachO] Add support for LC_VERSION_MIN_* load commands

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

> Which kind of blocks me. Unless we can fix it quickly, it be nice to revert this in the meantime. (I'll revert it locally for now to unblock me.)

Turns out it blocks me too, so I'm working on a fix...



================
Comment at: lld/MachO/InputFiles.cpp:154
+  }
+  if (platformInfo->minimum >= config->platformInfo.minimum)
+    return true;
----------------
thakis wrote:
> Should this just be `<=`? An .o file is compatible if it targets an older or at most as new platform as the output, right?
welp, I believe you're right


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100523/new/

https://reviews.llvm.org/D100523