[PATCH] D79097: [GVN] Improve analysis for missed optimization remark

[Adam Nemet via Phabricator via llvm-commits]

anemet added a comment.

Glad, you were able to get back to this.



================
Comment at: llvm/test/Transforms/GVN/opt-remarks-multiple-users.ll:15
+; CHECK-NEXT:   - String:          ' because it is clobbered by '
+; CHECK-NEXT:   - ClobberedBy:     call
+; CHECK-NEXT: ...
----------------
It seems that we want to be able to distinguish between the two calls here?

If you add source debug info to test along the lines of GVN/opt-remarks.ll you should be able to check that the right call is returned here.

Also a nit, you may want to chop up the CHECK section so that each checking section is right before the function it corresponds too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79097/new/

https://reviews.llvm.org/D79097