[PATCH] D99693: Update the linkage name of coro-split functions where applicable

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D99693#2709931 <https://reviews.llvm.org/D99693#2709931>, @aprantl wrote:

> I believe that this is purely a limitation of AsmPrinter and that we could probably change its behavior to emit different linkage names in different instances, but I have not looked at what various debuggers expect here and DWARF GCC emits for C++ coroutines. I was mostly focussed on getting the Swift case right, while not disturbing C++.

I'm with you there - I'm trying to remember/understand/gather that there's actually a problem with linkage names not matching DW_AT_linkage_names, so we know how to weigh the costs here/know what's broken and needs fixing.

I'm not sure what the right longer term path is - I haven't looked at what coroutine DWARF looks like, why we have (multiple?) functions using the same DW_AT_subprogram declaration? or why the functions name needs to change if it's not multiple of them... & how a DWARF consumer would deal with all that, whatever it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99693/new/

https://reviews.llvm.org/D99693