[PATCH] D101011: [Attr] Add "noipa" function attribute

Thu Apr 22 12:11:24 PDT 2021

xbolva00 added a comment.

In D101011#2709797 <https://reviews.llvm.org/D101011#2709797>, @dblaikie wrote:

> In D101011#2709757 <https://reviews.llvm.org/D101011#2709757>, @xbolva00 wrote:
>
>> Check leaf attribute: https://reviews.llvm.org/D90275
>>
>> I think you miss similar changes in SemaDeclAttr.cpp and CGCall.cpp and some testcases with
>>
>>   __attribute__((noipa))
>
> I'm not planning on adding the C noipa attribute to Clang (or at least not planning on doing it in this patch) - generally LLVM and Clang changes should be separated when possible, as they can in this case - the implementation and testing of the LLVM IR attribute can be done without changes to Clang, and should be done that way. Then Clang functionality can be built on top of that work in independent patches.

Oh, okay. I can take it then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101011/new/

https://reviews.llvm.org/D101011