[PATCH] D100998: [sanitizer] Use COMPILER_RT_EMULATOR with gtests

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 11:16:45 PDT 2021


delcypher added a comment.

In D100998#2709526 <https://reviews.llvm.org/D100998#2709526>, @vitalybuka wrote:

> In D100998#2709448 <https://reviews.llvm.org/D100998#2709448>, @delcypher wrote:
>
>> @vitalybuka Damn looks like you landed the patch while I was in the middle of writing a review. Could you make the fix I requested as a follow up patch?
>
> sure, sorry, I didn't noticed comments.
> I even can revert if there is serious issues.

@vitalybuka No problem. No need to revert. I don't think the patch will break anything that exists today but I would like to make sure the new `run_under` parameter gets typed checked so that it's easier for people to adopt it. Please create a follow up patch and add myself and @yln as reviewers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100998/new/

https://reviews.llvm.org/D100998



More information about the llvm-commits mailing list