[PATCH] D100951: [llvm-dwarfdump] Fix split-dwarf bug in stats for inlined var loc cov

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 08:15:28 PDT 2021


dblaikie added a comment.

In D100951#2707838 <https://reviews.llvm.org/D100951#2707838>, @djtodoro wrote:

> In D100951#2705718 <https://reviews.llvm.org/D100951#2705718>, @dblaikie wrote:
>
>> Generally good for me - but could you try to see if the test could be simplified any further (maybe "main" can be in test1 or test2 (replacing f1 or f2) and could call the other function in the other file) - and see if the auxiliary/input files could be represented as assembly instead of checked in object files?
>
> I am not sure how to keep this as assembly code, since we'd need to create object files of it, and then to link it together...

the dwo files should be able to be assembly without any particular restrictions/complications in authoring them, right? (taking the assembly of a split DWARF compilation and pulling out the .dwo parts should be adequate, I think)
The executable - it could probably actually be an object file that happens to have two skeleton units in it (like we generate under LTO, for instance - though without any of the LTO-specific cross-CU references) so that could be written in assembly relatively easily (to hand-craft it you could probably take the assembly of the two skeletons and copy/paste them into one file for instance)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100951/new/

https://reviews.llvm.org/D100951



More information about the llvm-commits mailing list