[lld] 7128146 - [lld/mac] tweak comment in a test
Nico Weber via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 22 08:15:12 PDT 2021
Author: Nico Weber
Date: 2021-04-22T11:14:58-04:00
New Revision: 71281462c856a14a0744b2e3b3fb4923be42bce6
URL: https://github.com/llvm/llvm-project/commit/71281462c856a14a0744b2e3b3fb4923be42bce6
DIFF: https://github.com/llvm/llvm-project/commit/71281462c856a14a0744b2e3b3fb4923be42bce6.diff
LOG: [lld/mac] tweak comment in a test
Added:
Modified:
lld/test/MachO/weak-private-extern.s
Removed:
################################################################################
diff --git a/lld/test/MachO/weak-private-extern.s b/lld/test/MachO/weak-private-extern.s
index 0a19f50ba957..641a88525883 100644
--- a/lld/test/MachO/weak-private-extern.s
+++ b/lld/test/MachO/weak-private-extern.s
@@ -16,7 +16,8 @@
## This is
diff erent from ld64, which makes private extern weak symbols non-weak
## for binds and relocations, but it still marks them as weak in the symbol table.
## Since `nm -m` doesn't look at N_WEAK_DEF for N_PEXT symbols this is not
-## observable, but it feels slightly more correct.
+## observable via nm, but it feels slightly more correct.
+## (It is observable in `llvm-objdump --syms` output.)
# RUN: llvm-readobj --syms %t.dylib | FileCheck --check-prefix=SYMS %s
# SYMS-NOT: WeakDef (0x80)
More information about the llvm-commits
mailing list