[lld] c1b2a7b - [lld/mac] make a few "named parameter comments" more consistent

[Nico Weber via llvm-commits]

Author: Nico Weber
Date: 2021-04-22T10:48:03-04:00
New Revision: c1b2a7bfbf559fecf7acb4a6fcb6ba731970a518

URL: https://github.com/llvm/llvm-project/commit/c1b2a7bfbf559fecf7acb4a6fcb6ba731970a518
DIFF: https://github.com/llvm/llvm-project/commit/c1b2a7bfbf559fecf7acb4a6fcb6ba731970a518.diff

LOG: [lld/mac] make a few "named parameter comments" more consistent

Most of LLVM and almost all of lld/MachO uses `/*foo=*/bar` style.
No behavior change.

Added: 
    

Modified: 
    lld/MachO/SyntheticSections.cpp
    lld/MachO/UnwindInfoSection.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/SyntheticSections.cpp b/lld/MachO/SyntheticSections.cpp
index 66e1effcaf0fc..1734b12faf29e 100644
--- a/lld/MachO/SyntheticSections.cpp
+++ b/lld/MachO/SyntheticSections.cpp
@@ -1102,7 +1102,7 @@ void macho::createSyntheticSymbols() {
   auto addHeaderSymbol = [](const char *name) {
     symtab->addSynthetic(name, in.header->isec, 0,
                          /*privateExtern=*/true,
-                         /*includeInSymtab*/ false);
+                         /*includeInSymtab=*/false);
   };
 
   switch (config->outputType) {
@@ -1114,13 +1114,13 @@ void macho::createSyntheticSymbols() {
     // Otherwise, it's an absolute symbol.
     if (config->isPic)
       symtab->addSynthetic("__mh_execute_header", in.header->isec, 0,
-                           /*privateExtern*/ false,
-                           /*includeInSymbtab*/ true);
+                           /*privateExtern=*/false,
+                           /*includeInSymbtab=*/true);
     else
       symtab->addSynthetic("__mh_execute_header",
                            /*isec*/ nullptr, 0,
-                           /*privateExtern*/ false,
-                           /*includeInSymbtab*/ true);
+                           /*privateExtern=*/false,
+                           /*includeInSymbtab=*/true);
     break;
 
     // The following symbols are  N_SECT symbols, even though the header is not

diff  --git a/lld/MachO/UnwindInfoSection.cpp b/lld/MachO/UnwindInfoSection.cpp
index b946424040911..924b40ba6d764 100644
--- a/lld/MachO/UnwindInfoSection.cpp
+++ b/lld/MachO/UnwindInfoSection.cpp
@@ -179,8 +179,9 @@ void UnwindInfoSectionImpl<Ptr>::prepareRelocations(InputSection *isec) {
       // symbols for them in the GOT.
       Symbol *&s = personalityTable[{referentIsec, r.addend}];
       if (s == nullptr) {
-        s = make<Defined>("<internal>", nullptr, referentIsec, r.addend, 0,
-                          false, false, false);
+        s = make<Defined>("<internal>", /*file=*/nullptr, referentIsec,
+                          r.addend, /*size=*/0, /*isWeakDef=*/false,
+                          /*isExternal=*/false, /*isPrivateExtern=*/false);
         in.got->addEntry(s);
       }
       r.referent = s;