[PATCH] D101065: [lld/mac] slightly improve weak-private-extern.s test

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: lld-macho.
Herald added a project: lld-macho.
thakis requested review of this revision.

- __got is in --bind output, so print that too (makes the test a bit stronger)
- WEAK_DEFINES, BINDS_TO_WEAK are in the mach-o header, so --private-header is enough, no need for --all-headers (makes the test a bit easier to work with when it fails)


https://reviews.llvm.org/D101065

Files:
  lld/test/MachO/weak-private-extern.s


Index: lld/test/MachO/weak-private-extern.s
===================================================================
--- lld/test/MachO/weak-private-extern.s
+++ lld/test/MachO/weak-private-extern.s
@@ -3,11 +3,11 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %s -o %t.o
 # RUN: %lld -dylib %t.o -o %t.dylib -lSystem
 
-# RUN: llvm-objdump --macho --weak-bind %t.dylib | FileCheck %s
+# RUN: llvm-objdump --macho --bind --weak-bind %t.dylib | FileCheck %s
 # CHECK-NOT: __got
 # CHECK-NOT: __la_symbol_ptr
 
-# RUN: llvm-objdump --macho --all-headers %t.dylib | \
+# RUN: llvm-objdump --macho --private-header %t.dylib | \
 # RUN:     FileCheck --check-prefix=HEADERS %s
 # HEADERS-NOT: WEAK_DEFINES
 # HEADERS-NOT: BINDS_TO_WEAK


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101065.339613.patch
Type: text/x-patch
Size: 739 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210422/edc6a094/attachment.bin>