[PATCH] D100649: [flang][driver] Fine-tune `-fdebug-dump-symbols`

Chirag Khandelwal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 07:00:21 PDT 2021


AMDChirag added inline comments.


================
Comment at: flang/lib/Frontend/FrontendActions.cpp:284
 void DebugDumpSymbolsAction::ExecuteAction() {
+  CompilerInstance &ci = this->instance();
   auto &semantics = this->semantics();
----------------
awarzynski wrote:
> AMDChirag wrote:
> > Shouldn't the local variables be named in PascalCase?
> In LLVM/Clang - yes, in MLIR/Flang -no :) It's basically lowerCase everywhere in Flang. That's not really explicitly mentioned in the [[ https://releases.llvm.org/11.0.0/tools/flang/docs/C++style.html | coding style ]], but that's the style used in this file and in other parts of Flang.
Oh okay, my bad. Thanks for explaining :)
LGTM, but i'll let others take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100649/new/

https://reviews.llvm.org/D100649



More information about the llvm-commits mailing list