[PATCH] D97503: [AIX] Allow safe for 32bit P9 VSX extract and insert pattern matches

Thu Apr 22 06:40:35 PDT 2021

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

The patch is functionally fine but please address the pattern ordering nit on the commit.

================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:4155

-// (Un)Signed DWord vector extract -> QP
-def : Pat<(f128 (sint_to_fp (i64 (extractelt v2i64:$src, 0)))),
----------------
The new ordering is weird. We used to have handling for `i64/f64` followed by `f128`. Now it seems that we have `i64/f64`, then `f64` then `f128` then `i64` then `f128`.

Please just leave these here, and put all the existing and new `i64/f64` above.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97503/new/

https://reviews.llvm.org/D97503