[lld] 4878851 - [lld/mac] add a comment pointing to a test that took me a while to find
Nico Weber via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 22 06:10:18 PDT 2021
Author: Nico Weber
Date: 2021-04-22T09:09:55-04:00
New Revision: 487885129c3a8d5cfa22b657e1a82d5b78170bf0
URL: https://github.com/llvm/llvm-project/commit/487885129c3a8d5cfa22b657e1a82d5b78170bf0
DIFF: https://github.com/llvm/llvm-project/commit/487885129c3a8d5cfa22b657e1a82d5b78170bf0.diff
LOG: [lld/mac] add a comment pointing to a test that took me a while to find
Added:
Modified:
lld/test/MachO/private-extern.s
lld/test/MachO/weak-private-extern.s
Removed:
################################################################################
diff --git a/lld/test/MachO/private-extern.s b/lld/test/MachO/private-extern.s
index c8c96aa8e7b3a..320e1a97232d0 100644
--- a/lld/test/MachO/private-extern.s
+++ b/lld/test/MachO/private-extern.s
@@ -20,6 +20,9 @@
# EXPORTS-NM-DAG: (__TEXT,__cstring) non-external (was a private external) _foo
# EXPORTS-NM-DAG: (__TEXT,__cstring) external _bar
+# Tests that weak private_exten symbols aren't referenced in the
+# weak bind table are in weak-private.extern.s
+
#--- basics.s
.section __TEXT,__cstring
diff --git a/lld/test/MachO/weak-private-extern.s b/lld/test/MachO/weak-private-extern.s
index 78fb4260999c6..0a19f50ba9578 100644
--- a/lld/test/MachO/weak-private-extern.s
+++ b/lld/test/MachO/weak-private-extern.s
@@ -2,6 +2,7 @@
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %s -o %t.o
# RUN: %lld -dylib %t.o -o %t.dylib -lSystem
+
# RUN: llvm-objdump --macho --weak-bind %t.dylib | FileCheck %s
# CHECK-NOT: __got
# CHECK-NOT: __la_symbol_ptr
More information about the llvm-commits
mailing list