[PATCH] D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O

Abhina Sree via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 05:44:12 PDT 2021


abhina.sreeskantharajan marked 2 inline comments as done.
abhina.sreeskantharajan added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:999
+
+#ifdef __MVS__
+  /* Reason about auto-conversion and file tags. Setting the file tag only
----------------
SeanP wrote:
> Some places use `#ifdef` and others `#if defined(__MVS__)`.  We should be consistent.
Thanks Sean. There's seems to be mixed use in this file, so I just updated all uses of MVS in this patch to be #ifdef for consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100483/new/

https://reviews.llvm.org/D100483



More information about the llvm-commits mailing list