[PATCH] D99774: [LoopUtils] Populate sibling loops in reverse program order on new pass manager

Thu Apr 22 03:42:58 PDT 2021

fhahn added a comment.

In D99774#2705058 <https://reviews.llvm.org/D99774#2705058>, @jaykang10 wrote:

> In D99774#2704838 <https://reviews.llvm.org/D99774#2704838>, @fhahn wrote:
>
>> Could you share any data of the impact this change has on runtime-performance/code-size on benchmarks?
>
> I have checked exec_time/size with llvm-test-suite on x86 and the result is as below.

Thanks for sharing the data, but I am not sure the excerpt you shared motivates a change? The SingleSource/short-running ones probably do not provide much insight. I think the results for MultiSource/SPEC would be more interesting. In how many binaries does the patch cause changes? How does it impact runtime performance for longer benchmarks?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99774/new/

https://reviews.llvm.org/D99774