[PATCH] D100938: neon: truncate(smin(smax(a,b),c)) --> vqmovns(a),truncate(smin(a,b)) --> vqmovnu(a)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 03:27:20 PDT 2021


RKSimon added a comment.

In D100938#2707800 <https://reviews.llvm.org/D100938#2707800>, @fantasyRqg wrote:

> In D100938#2707735 <https://reviews.llvm.org/D100938#2707735>, @RKSimon wrote:
>
>> X86 has some very similar code to recognise saturated trunc pattern matchers (detectUSatPattern + detectSSatPattern) - would it make sense to move them to SelectionDAG and reuse them here?
>
> I will take a look. 
> I need some time to understand TableGen.

I didn't mean anything for TableGen - I just mention reusing the existing code (after moving to a generic location) instead of your IsSignedSaturate/IsUnsignedSaturate lambdas


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100938/new/

https://reviews.llvm.org/D100938



More information about the llvm-commits mailing list