[PATCH] D100446: [Transforms][Debugify] Fix "Missing line" false alarm on PHI nodes

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 02:06:33 PDT 2021


xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/Debugify.cpp:140
       for (Instruction &I : BB)
         I.setDebugLoc(DILocation::get(Ctx, NextLine++, 1, SP));
 
----------------
Or we don't set debugloc for PHI.


================
Comment at: llvm/lib/Transforms/Utils/Debugify.cpp:495
         if (isa<PHINode>(I))
           continue;
 
----------------
Here also ship PHI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100446/new/

https://reviews.llvm.org/D100446



More information about the llvm-commits mailing list