[PATCH] D101005: [AArch64][GlobalISel] Simplify out of range rotate amount.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3924
+  auto Bits = Builder.buildConstant(AmtTy, Bitsize);
+  ConstantFoldingMIRBuilder CFMIB(MI);
+  Amt = CFMIB.buildURem(AmtTy, MI.getOperand(2).getReg(), Bits).getReg(0);
----------------
arsenm wrote:
> arsenm wrote:
> > aemerson wrote:
> > > arsenm wrote:
> > > > aemerson wrote:
> > > > > arsenm wrote:
> > > > > > I think one off MIRBuilders should never be used
> > > > > What do you suggest here instead?
> > > > The combiner helper should have a universal builder
> > > The universal builder is a CSE one, and I need a constant folding one here. Maybe CSE should do it too?
> > I honestly don't see the point of having all of these MIRBuilder flavors. Why don't we have just one that does everything?
> I thought the CSE builder did do constant folding. Also can't you just directly call the constant folding utility function?
Yes the CSE builder does constant folding. I think ConstantFoldingMIRBuilder should be deleted. It's unused and I was told it was just an experiment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101005/new/

https://reviews.llvm.org/D101005