[PATCH] D100835: [WIP][LLD][RISCV] Linker Relaxation

Thu Apr 22 00:45:38 PDT 2021

MaskRay added a comment.

In D100835#2701062 <https://reviews.llvm.org/D100835#2701062>, @jrtc27 wrote:

> Why write your own deleteRanges? I took great care in writing mine to ensure there were no hidden quadratic complexities, but your simpler version has introduced them. Just take mine, unless there is a problem with it nobody's mentioned. Same goes for mutableData being a less efficient version of mine.
>
> I also don't like making this overly target-specific. We should take the time to get the interface right, not just punt on it and shove it all into target-specific code.

+1 for a low time complexity implementation. The quadratic time complexity of the binutils approach may run into scalability problems.

I haven't closely looked into this yet, but it seems that `R_RISCV_GPREL_*` support can be contributed separately.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100835/new/

https://reviews.llvm.org/D100835