[PATCH] D100649: [flang][driver] Fine-tune `-fdebug-dump-symbols`

Chirag Khandelwal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 00:39:33 PDT 2021


AMDChirag requested changes to this revision.
AMDChirag added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Frontend/FrontendActions.cpp:284
 void DebugDumpSymbolsAction::ExecuteAction() {
+  CompilerInstance &ci = this->instance();
   auto &semantics = this->semantics();
----------------
Shouldn't the local variables be named in PascalCase?


================
Comment at: flang/lib/Frontend/FrontendActions.cpp:295
+
+  auto tables{Fortran::semantics::BuildRuntimeDerivedTypeTables(
+      instance().invocation().semanticsContext())};
----------------
PascalCase here as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100649/new/

https://reviews.llvm.org/D100649



More information about the llvm-commits mailing list