[PATCH] D101004: [CodeGen] Do not split functions with attr "implicit-section-name".

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:104
   // split functions within the same section as specified by the attribute.
-  if (!MF.getFunction().getSection().empty())
+  if (!MF.getFunction().getSection().empty() ||
+      MF.getFunction().hasFnAttribute("implicit-section-name"))
----------------
rahmanl wrote:
> nit: Can you use `hasSection()` here to be more consistent with TargetLoweringObjectFile.cpp?
Looks like this is not consistent even though the documentation suggests that they should be equivalent, so I'll revert it for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101004/new/

https://reviews.llvm.org/D101004