[PATCH] D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O

[Sean via Phabricator via llvm-commits]

SeanP added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:999
+
+#ifdef __MVS__
+  /* Reason about auto-conversion and file tags. Setting the file tag only
----------------
Some places use `#ifdef` and others `#if defined(__MVS__)`.  We should be consistent.


================
Comment at: llvm/test/Support/encoding.ll:6
+;
+; RUN: cat %s >%t && chtag -tc 819 %t && llc %t -o - >/dev/null
+; RUN: iconv -f 819 -t 1047 <%s >%t && chtag -tc 1047 %t && llc %t -o - >/dev/null
----------------
minor nit. Rather than using the short names 819 & 1047 we should use the full names iso8859-1 & ibm-1047.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100483/new/

https://reviews.llvm.org/D100483