[PATCH] D100912: [docs][NewPM] Add section on analyses

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 17:37:09 PDT 2021


ychen added a comment.

Thanks for writing this up. It is very helpful. Some comments inline.



================
Comment at: llvm/docs/NewPassManager.rst:243
+    // Invalidate all analysis results for function F
+    FAM.invalidate(F, PreservedAnalyses::none());
+
----------------
It would be great to mention that we only do this for inner proxy and in the condition that it matters for performance. In other cases, users should stick with retuned PreservedAnalyses.


================
Comment at: llvm/docs/NewPassManager.rst:259
+
+Analysis Invalidation
+=====================
----------------
How about calling it `Dependent analysis Invalidation` or `Analysis Invalidation Propagation` or something similar? I think that's the motivation for `PassResult::invalidate`.  Personally `Analysis Invalidation` reminds me of the returned `PreservedAnalyses` which is related but not exactly the same thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100912/new/

https://reviews.llvm.org/D100912



More information about the llvm-commits mailing list