[PATCH] D101004: [CodeGen] Do not split functions with attr "implicit-section-name".

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 17:20:25 PDT 2021


rahmanl accepted this revision.
rahmanl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:104
   // split functions within the same section as specified by the attribute.
-  if (!MF.getFunction().getSection().empty())
+  if (!MF.getFunction().getSection().empty() ||
+      MF.getFunction().hasFnAttribute("implicit-section-name"))
----------------
nit: Can you use `hasSection()` here to be more consistent with TargetLoweringObjectFile.cpp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101004/new/

https://reviews.llvm.org/D101004



More information about the llvm-commits mailing list