[PATCH] D83578: [test] Replace a fragile lit feature (substitution in an argument place) with command -v

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 339427.
MaskRay added a comment.

Fix llvm-objdump

I think this  is still better than the current replacement at non argv[0] place.

This does add more reliance on `PATH` (which is already being relied upon), but if this is deemed brittle, we can let lit recognize `command -v tool` as a special form.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83578/new/

https://reviews.llvm.org/D83578

Files:
  llvm/test/tools/llvm-ar/tool-name.test
  llvm/test/tools/llvm-dlltool/tool-name.test
  llvm/test/tools/llvm-lib/tool-name.test
  llvm/test/tools/llvm-objcopy/tool-name.test
  llvm/test/tools/llvm-objdump/tool-name.test
  llvm/test/tools/llvm-ranlib/tool-name.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83578.339427.patch
Type: text/x-patch
Size: 4398 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210422/36a73c0a/attachment.bin>