[PATCH] D100236: AMDGPU: Restore atomic fp feature on FP atomic instruction definitions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 17:14:56 PDT 2021


arsenm added a comment.

In D100236#2680845 <https://reviews.llvm.org/D100236#2680845>, @rampitec wrote:

> In D100236#2680838 <https://reviews.llvm.org/D100236#2680838>, @arsenm wrote:
>
>> In D100236#2680833 <https://reviews.llvm.org/D100236#2680833>, @rampitec wrote:
>>
>>> We should not produce this for gfx803.
>>
>> We need to produce something. The expectation is the function should be dynamically dead.
>
> The feature itself is not sufficient, you cannot just expand atomicrmw into this without knowledge of other target properties. Unfortunately these has changed since first defined.

What other target properties? This is supposed to be the target property to say the instruction is available


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100236/new/

https://reviews.llvm.org/D100236



More information about the llvm-commits mailing list