[PATCH] D100528: [CSSPGO][llvm-profdata] Support trimming cold context when merging profiles

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

The dependency on Analysis should be removed in the latest version.



================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:887-891
+  cl::opt<bool> SampleMergeColdContext(
+      "sample-merge-cold-context", cl::init(false), cl::Hidden,
+      cl::desc(
+          "Merge context sample profiles whose count is below cold threshold"));
+  cl::opt<bool> SampleTrimColdContext(
----------------
wmi wrote:
> What will happen if these two flags are enabled for non-CSSPGO sample profile?
Good catch, they should be ignored. Added a check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100528/new/

https://reviews.llvm.org/D100528