[PATCH] D89707: [CSSPGO][llvm-profgen] Parse mmap events from perf script

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/lit.local.cfg:6
+if not lit.util.which("llvm-profgen", config.llvm_tools_dir):
+  config.unsupported = True  
----------------
thakis wrote:
> thakis wrote:
> > Out of interest, why is this here? llvm-profgen is part of the llvm build and should always exist, right (…assuming you add it to LLVM_TEST_DEPENDS in llvm/test/CmakeLists.txt – is there a reason to not add it there?)? No other tool test has a check like this as far as I know.
> Looks like it's in LLVM_TEST_DEPENDS nowadays. Maybe these two lines can go now?
Good point. Yes, with llvm-profgen included in LLVM_TEST_DEPENDS, it should always be rebuilt and available at test time. The two lines are unnecessary. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89707/new/

https://reviews.llvm.org/D89707