[PATCH] D100923: [ConstFold] Constant fold load through invariant group intrinsics

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks planned changes to this revision.
aeubanks added a comment.

In D100923#2706417 <https://reviews.llvm.org/D100923#2706417>, @nikic wrote:

> This looks like a pretty serious layering violation, in that constants folding is now no longer folding constants. LLVM pretty strictly separates ConstantFold (folding instructions with all-constant operands), InstSimplify (folding instructions to a constant or existing instruction) and InstCombine (folding arbitrarily). This patch blurs the line between ConstantFold and InstSimplify.

That makes sense.
So instead I should add a `SimplifyFold` to `llvm::SimplifyInstruction`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100923/new/

https://reviews.llvm.org/D100923