[PATCH] D100995: [WebAssembly] Put utility functions in Utils directory (NFC)

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 13:39:31 PDT 2021


aheejin added a comment.

@wingo, I wanted to merge WebAssembly::getOrCreateFunctionTableSymbol <https://github.com/llvm/llvm-project/blob/5d1c43f333c2327be61604dc90ea675f0d1e6913/llvm/lib/Target/WebAssembly/WebAssemblyUtilities.cpp#L100-L117> in WebAssemblyUtilities.cpp and GetOrCreateFunctionTableSymbol <https://github.com/llvm/llvm-project/blob/5d1c43f333c2327be61604dc90ea675f0d1e6913/llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp#L177-L190> in WebAssemblyAsmParser.cpp and put it in Utils/WebAssemblyUtilities.cpp, but it looks they became diverged in D90948 <https://reviews.llvm.org/D90948> and are not the same anymore. Can they still be merged?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100995/new/

https://reviews.llvm.org/D100995



More information about the llvm-commits mailing list