[PATCH] D100994: [MC] Set addrsig symbol as weak/weakExternal

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 13:24:02 PDT 2021


pcc added a comment.

Wouldn't this make all address significant symbols weak external?

The intent is that we don't emit additional symbols if the address significance table is enabled (see e.g. the call to GV.use_empty() before calling emitAddrsigSym in llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp). If you're still seeing undefined symbols with that, I think we need to make that condition more powerful instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100994/new/

https://reviews.llvm.org/D100994



More information about the llvm-commits mailing list