[PATCH] D100966: [lld-link] Ignore undefined symbols in .addrsig table

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 13:13:42 PDT 2021


zequanwu abandoned this revision.
zequanwu added a comment.

In D100966#2705542 <https://reviews.llvm.org/D100966#2705542>, @MaskRay wrote:

> This is not correct. A symbol marked by `.addrsig_sym` can be referenced via normal means. With this patch, the diagnostic may change from `error: undefined symbol: bar` to `error: relocation against symbol in discarded section: bar`

Thanks for pointing it out. I put a new patch here: D100994 <https://reviews.llvm.org/D100994>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100966/new/

https://reviews.llvm.org/D100966



More information about the llvm-commits mailing list