[PATCH] D88395: [LoopReroll] Fix rerolling loop with extra instructions

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Looks much simpler now ;-)

I will accept after fixing the LLVM_DEBUG message.

It has a lot fewer tests now, any reason to remove some tests (to clirify: I tihnk the current 3 tests are sufficient)

After that, would you like me to push the patch to the repository's main branch? Potentially also include it in release 12.0.1?



================
Comment at: llvm/lib/Transforms/Scalar/LoopRerollPass.cpp:1085
+      LLVM_DEBUG(dbgs() << "LRR: Aborting - An instruction which does not "
+                        << "belongs to any root sets may have side effects: "
+                        << *I);
----------------
[typo] An instruction which does not belong~~s~~ to any root __must not__ have side effects


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88395/new/

https://reviews.llvm.org/D88395