[PATCH] D100909: [MC] Use COMDAT for LSDA only if IR comdat type is any

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:897
     Group = C->getName();
+    IsComdat = C->getSelectionKind() == Comdat::Any;
   }
----------------
MaskRay wrote:
> phosek wrote:
> > MaskRay wrote:
> > > IsComdat -> IsComdatAny
> > > 
> > > 
> > We use `IsComdat` elsewhere in this file so I'd prefer to keep them consistent.
> But the name is now confusing. This now specifically refers to Comdat::Any. Readers could interpret IsComdat as any comdat kind.
That name is referring to the name of the `getELFSection` argument which is called `IsComdat`, not to its value. I'm fine changing the name if you want, but I'd prefer doing it consistently across the entire file in a follow up change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100909/new/

https://reviews.llvm.org/D100909