[PATCH] D100380: [Polly] In getBuild() use isl::noexception bindings [NFC]

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: polly/lib/CodeGen/IslAst.cpp:711
 
-    isl::ast_build Build = isl::manage_copy(IslAstInfo::getBuild(Node));
+    isl::ast_build Build = IslAstInfo::getBuild(isl::manage(Node));
     if (MemAcc->isAffine()) {
----------------
I think this needs to be `isl::manage_copy` as the previous annotation for the argument was `__isl_keep`.


================
Comment at: polly/lib/CodeGen/IslNodeBuilder.cpp:856
 
-  auto *Build = IslAstInfo::getBuild(Node);
-  assert(Build && "Could not obtain isl_ast_build from user node");
-  Stmt->setAstBuild(isl::manage_copy(Build));
+  isl::ast_build Build = IslAstInfo::getBuild(isl::manage(Node));
+  assert(!Build.is_null() && "Could not obtain isl_ast_build from user node");
----------------
I think this needs to be `isl::manage_copy` as the previous annotation for the argument was `__isl_keep`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100380/new/

https://reviews.llvm.org/D100380