[PATCH] D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1

Anirudh Prasad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 10:41:57 PDT 2021


anirudhp added a comment.

In D98276#2705806 <https://reviews.llvm.org/D98276#2705806>, @abhina.sreeskantharajan wrote:

> Is it possible to add partial unit tests like you did in your previous patches?

No (atleast from the top of my head). The very instantiation of the Parser instance is dependent on the target triple itself. And since we don't really have other object writer/streamer support yet, there's no way to instantiate for z/OS (even in the unit test). Also, writing tests end to test the end to end implementation for the parser would be a tremendous amount of work (comparing it to writing simple mc tests).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98276/new/

https://reviews.llvm.org/D98276



More information about the llvm-commits mailing list