[PATCH] D100332: [CSSPGO] Flip SkipPseudoOp to true for MIR APIs.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 09:19:50 PDT 2021


hoy added a comment.

In D100332#2705447 <https://reviews.llvm.org/D100332#2705447>, @hoy wrote:

> In D100332#2705180 <https://reviews.llvm.org/D100332#2705180>, @thakis wrote:
>
>> In D100332#2701895 <https://reviews.llvm.org/D100332#2701895>, @hoy wrote:
>>
>>> In D100332#2701572 <https://reviews.llvm.org/D100332#2701572>, @chill wrote:
>>>
>>>> Apologies if you're already aware.
>>>>
>>>> It appears with this change an expensive checks buildbot started to fail: https://lab.llvm.org/buildbot/#/builders/16/builds/9542
>>>
>>> Thanks for letting me know. The failures should be fixed by D100334 <https://reviews.llvm.org/D100334>.



>> Looks like it's still failing at today's trunk even with that change: https://lab.llvm.org/buildbot/#/builders/16/builds/9678
>
> I see. It's failing with -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON. I'm taking a look. Thanks.

I just pushed in a fix:  https://reviews.llvm.org/rGb6db6f5530d2 .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100332/new/

https://reviews.llvm.org/D100332



More information about the llvm-commits mailing list