[PATCH] D100939: [ExpandPostRAPseudos] Don't add duplicate implicit operands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 08:28:44 PDT 2021


arsenm added a comment.

In D100939#2705343 <https://reviews.llvm.org/D100939#2705343>, @rampitec wrote:

> In D100939#2704630 <https://reviews.llvm.org/D100939#2704630>, @foad wrote:
>
>> For AMDGPU should this be fixed earlier, by not putting the "implicit $exec" on a COPY? I don't understand whether they are required or not.
>
> It was done to prevent rescheduling VGPR COPYs across EXEC modifications. Still needed I believe.

I don't think the way we throw implicit exec uses on COPYs at certain points is entirely sound. It's not applied consistently (and would really need to be present on copy creation)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100939/new/

https://reviews.llvm.org/D100939



More information about the llvm-commits mailing list