[PATCH] D100944: [CodeGen][ELF] Emit separate unique sections for different flags

Wed Apr 21 08:23:10 PDT 2021

bd1976llvm added a comment.

Hi. Can you add some background information to the description. I assume the discussion on https://reviews.llvm.org/D93948 is relevant. Is there an associated bug?

One of the goals when I put in a fix for https://bugs.llvm.org/show_bug.cgi?id=43457 was to try to minimise the circumstances under which MC would have to use a "unique" section. So, I think with this change some of the testcases in explicit-section-mergeable.ll will no longer be relevant e.g. the "Non-allocatable "default" sections can have allocatable mergeable symbols with compatible entry sizes assigned to them" case - and there are probably more. If this review progresses I will try to examine all of the testcases and see what can be simplified.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100944/new/

https://reviews.llvm.org/D100944