[PATCH] D100381: [RFC] Improve loop distribute cost model

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D100381#2704830 <https://reviews.llvm.org/D100381#2704830>, @fhahn wrote:

> In D100381#2704777 <https://reviews.llvm.org/D100381#2704777>, @sanwou01 wrote:
>
>> (snip)
>>
>> So, unfortunately, it looks like we can't handle these loops without some pretty fundamental changes to LoopAccessAnalysis. Thoughts?
>
> Yes, those are known limitations and I would recommend focusing on showing loop-distribute's value with current LAA.

On a general comment, I highly recommend trying to be incremental and fixing one set of issues at a time.  If you can show benefit with current LAA, do that.  If you can't and need to change LAA in some way, go do that and show the benefit on it's own.  Trying to do too many things at once is recipe for failure.

(p.s. I know very little about the specific code in loop-distribute.  This is just a general comment.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100381/new/

https://reviews.llvm.org/D100381